Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: re-enable sandboxing #79577

Merged

Conversation

irfansharif
Copy link
Contributor

@irfansharif irfansharif commented Apr 7, 2022

#79360 disable sandboxing for all things but code-gen; we've seen build
failures as a result. This commit reverts it while we investigate.

Release note: None

@irfansharif irfansharif requested a review from rickystewart April 7, 2022 14:12
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@irfansharif irfansharif requested a review from a team April 7, 2022 14:15
@irfansharif irfansharif changed the title bazel: re-enabled sandboxing for c-deps bazel: re-enable sandboxing for c-deps Apr 7, 2022
\cockroachdb#79360 disable sandboxing for all things but code-gen; we've seen build
failures as a result. This commit reverts it while we investigate.

Release note: None
@irfansharif irfansharif force-pushed the 220407.enable-sandboxing-cdeps branch from f3fa8f4 to 3b4fd10 Compare April 7, 2022 14:19
@irfansharif
Copy link
Contributor Author

bors r+ p=99

@irfansharif irfansharif changed the title bazel: re-enable sandboxing for c-deps bazel: re-enable sandboxing Apr 7, 2022
@craig
Copy link
Contributor

craig bot commented Apr 7, 2022

Build succeeded:

@craig craig bot merged commit 4940bc1 into cockroachdb:master Apr 7, 2022
@irfansharif irfansharif deleted the 220407.enable-sandboxing-cdeps branch April 7, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants