Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.1: kvserver/loqrecovery: persist new replica ID in RaftReplicaID #80625

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 27, 2022

Backport 2/2 commits from #80470 on behalf of @erikgrinaker.

/cc @cockroachdb/release


cli: persist new replica ID in unsafe-remove-dead-replicas

The recently introduced local RaftReplicaIDKey was not updated when
unsafe-remove-dead-replicas changed the replica's ID. This could lead
to assertion failures.

Touches #75133.
Touches #79074.

Release note: None

kvserver/loqrecovery: persist new replica ID in RaftReplicaID

The recently introduced local RaftReplicaIDKey was not updated when
loss of quorum recovery changed the replica's ID. This could lead to
assertion failures.

Release note: None


Release justification: fixes an internal invariant violation which we'll start relying on in 22.2.

The recently introduced local `RaftReplicaIDKey` was not updated when
`unsafe-remove-dead-replicas` changed the replica's ID. This could lead
to assertion failures.

Release note: None
The recently introduced local `RaftReplicaIDKey` was not updated when
loss of quorum recovery changed the replica's ID. This could lead to
assertion failures.

Release note: None
@blathers-crl blathers-crl bot requested review from a team as code owners April 27, 2022 11:02
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-80470 branch from 8601866 to 6fe5748 Compare April 27, 2022 11:02
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 27, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 27, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker requested a review from tbg April 28, 2022 09:27
@erikgrinaker erikgrinaker merged commit e01d259 into release-22.1 Apr 28, 2022
@erikgrinaker erikgrinaker deleted the blathers/backport-release-22.1-80470 branch April 28, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants