release-22.1: kvserver/loqrecovery: persist new replica ID in RaftReplicaID
#80625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #80470 on behalf of @erikgrinaker.
/cc @cockroachdb/release
cli: persist new replica ID in
unsafe-remove-dead-replicas
The recently introduced local
RaftReplicaIDKey
was not updated whenunsafe-remove-dead-replicas
changed the replica's ID. This could leadto assertion failures.
Touches #75133.
Touches #79074.
Release note: None
kvserver/loqrecovery: persist new replica ID in
RaftReplicaID
The recently introduced local
RaftReplicaIDKey
was not updated whenloss of quorum recovery changed the replica's ID. This could lead to
assertion failures.
Release note: None
Release justification: fixes an internal invariant violation which we'll start relying on in 22.2.