backupccl: break dependency to testcluster #80773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfansharif
requested review from
a team and
msbutler
and removed request for
a team
|
This change is |
irfansharif
force-pushed
the
220429.backupccl-testcluster
branch
from
3a23383 to
1494798
Compare
Noticed we were building testing library packages when building CRDB
binaries.
$ bazel query "somepath(//pkg/cmd/cockroach-short, //pkg/testutils/testcluster)"
//pkg/cmd/cockroach-short:cockroach-short
//pkg/cmd/cockroach-short:cockroach-short_lib
//pkg/ccl:ccl
//pkg/ccl/backupccl:backupccl
//pkg/testutils/testcluster:testcluster
Release note: None
irfansharif
force-pushed
the
220429.backupccl-testcluster
branch
from
1494798 to
bd36058
Compare
stevendanna
approved these changes
Apr 29, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed we were building testing library packages when building CRDB
binaries.
Release note: None