Revert "vendor: bump panicparse" #81126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a3b9d02. Local builds are failing when trying to pull panicparse, or parse it, or something. Release note: None
|
This change is |
irfansharif
approved these changes
May 8, 2022
There was a problem hiding this comment.
Looks like we knew about this at some point: cockroachdb/panicparse@604c82a. Maybe the right fix is pointing to our fork of whatever SHA we want + deleting that file again. This is silly though, LGTM until we have the proper fix.
|
bors r=[irfansharif] |
|
Build succeeded: |
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
May 13, 2022
This is a reincarnation of cockroachdb#81089, which was reverted in cockroachdb#81126. This time around, we pick up upstream PR [78] which renames the unicode file that prompted cockroachdb#81126. [78]: maruel/panicparse#78 Release note: None
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
May 13, 2022
This is a reincarnation of cockroachdb#81089, which was reverted in cockroachdb#81126. This time around, we pick up upstream PR [78] which renames the unicode file that prompted cockroachdb#81126. [78]: maruel/panicparse#78 Release note: None
craig bot
pushed a commit
that referenced
this pull request
May 14, 2022
81240: vendor: bump panicparse to v2.2.2 r=HonoreDB,rickystewart a=tbg This is a reincarnation of #81089, which was reverted in #81126. This time around, we pick up upstream PR [78] which renames the unicode file that prompted #81126. [78]: maruel/panicparse#78 Release note: None Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a3b9d02.
Local builds are failing when trying to pull panicparse, or
parse it, or something.
ERROR: /Users/azinger/go/src/github.com/cockroachdb/cockroach/pkg/server/debug/goroutineui/BUILD.bazel:3:11: //pkg/server/debug/goroutineui:goroutineui depends on @com_github_maruel_panicparse_v2//stack:stack in repository @com_github_maruel_panicparse_v2 which failed to fetch. no such package '@com_github_maruel_panicparse_v2//stack': java.io.IOException: Error extracting /private/var/tmp/_bazel_azinger/677d787319b81c8ea9837e0e004739a0/external/com_github_maruel_panicparse_v2/temp16121196517904253508/com_github_maruel_panicparse_v2-v2.2.1.zip to /private/var/tmp/_bazel_azinger/677d787319b81c8ea9837e0e004739a0/external/com_github_maruel_panicparse_v2/temp16121196517904253508: /private/var/tmp/_bazel_azinger/677d787319b81c8ea9837e0e004739a0/external/com_github_maruel_panicparse_v2/cmd/panic/internal/utf8/?tf8.go (Illegal byte sequence)Release note: None
Fixes #81122