Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: execbuilder: fix a rare flake #82648

Merged
merged 1 commit into from
Jun 9, 2022
Merged

release-22.1: execbuilder: fix a rare flake #82648

merged 1 commit into from
Jun 9, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 9, 2022 •
edited by yuzefovich
Loading

Backport 1/1 commits from #82642 on behalf of @yuzefovich.

/cc @cockroachdb/release

This commit fixes a rare flake in the vectorize_local test. I don't
quite understand why the test flakes tbh, but deduplicating the messages
from the trace makes it non-flaky while still ensuring that the test
exercises what it is intended to (that two spans are scanned in
parallel).

Fixes: #81636.

Release note: None

Release justification: test fix.

@yuzefovich
execbuilder: fix a rare flake
7821cd7 
This commit fixes a rare flake in the `vectorize_local` test. I don't
quite understand why the test flakes tbh, but deduplicating the messages
from the trace makes it non-flaky while still ensuring that the test
exercises what it is intended to (that two spans are scanned in
parallel).

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner June 9, 2022 04:02
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.1-82642 branch from d69a5b4 to 7821cd7 Compare June 9, 2022 04:02
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 9, 2022 •
edited by yuzefovich
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from cucaroach and msirek June 9, 2022 04:02
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 9, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

msirek
msirek approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)

@yuzefovich yuzefovich merged commit a03914a into release-22.1 Jun 9, 2022
@yuzefovich yuzefovich deleted the blathers/backport-release-22.1-82642 branch June 9, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msirek msirek msirek approved these changes

@cucaroach cucaroach Awaiting requested review from cucaroach

Assignees

@yuzefovich yuzefovich

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @msirek @yuzefovich