kvclient: rename all Del operations to Delete
#83799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the experimental markers for MVCC range tombstones, by renaming functions, methods, and parameters to not include `experimental`, as well as warning comments. The changes are entirely mechanical. Release note: None
|
This change is |
erikgrinaker
requested review from
a team
and removed request for
a team and
msbutler
erikgrinaker
force-pushed
the
kv-del-delete
branch
from
c824048 to
c055d26
Compare
This patch renames the following client methods on `DB`, `Batch`, and `Txn`: * `Del` → `Delete` * `DelRange` → `DeleteRange` * `DelRangeUsingTombstone` → `DeleteRangeUsingTombstone` The actual gRPC and MVCC APIs all use the full `Delete` term for these operations, with the client library being the odd one out. This can often lead to inconsistent terminology being used by teams on either side of the KV API boundary. Release note: None
erikgrinaker
force-pushed
the
kv-del-delete
branch
from
c055d26 to
40253de
Compare
|
Meh, going to drop this since we're in stability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is #83772.
This patch renames the following client methods on
DB,Batch, andTxn:Del→DeleteDelRange→DeleteRangeDelRangeUsingTombstone→DeleteRangeUsingTombstoneThe actual gRPC and MVCC APIs all use the full
Deleteterm for theseoperations, with the client library being the odd one out. This can
often lead to inconsistent terminology being used by teams on either
side of the KV API boundary.
Release note: None