sql: add user_id column to system.role_options table

[RichardJCai]

The system.role_options user_id column is populated after
the system.users user_id column is populated in the case of the
migration.

Release note: None

[cockroach-teamcity]

This change is 

[RichardJCai]

This PR borrows a lot from #81457 - the PR to add the user_id column to system.users but should be slightly more straightforward since we no longer have to generate IDs, they should exist in system.users already

[ajwerner]

This seems fine.

Reviewed 4 of 4 files at r1, 30 of 57 files at r2, 1 of 2 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner, @rafiss, @RichardJCai, and @stevendanna)

---

pkg/bench/rttanalysis/testdata/benchmark_expectations line 32 at r3 (raw file):

14,CreateRole/create_role_with_1_option
17,CreateRole/create_role_with_2_options
20,CreateRole/create_role_with_3_options

how come these are going up?

Code quote:

14,CreateRole/create_role_with_1_option
17,CreateRole/create_role_with_2_options
20,CreateRole/create_role_with_3_options
15,CreateRole/create_role_with_no_options

[RichardJCai]

This seems fine.

Reviewed 4 of 4 files at r1, 30 of 57 files at r2, 1 of 2 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner, @rafiss, @RichardJCai, and @stevendanna)

pkg/bench/rttanalysis/testdata/benchmark_expectations line 32 at r3 (raw file):

14,CreateRole/create_role_with_1_option
17,CreateRole/create_role_with_2_options
20,CreateRole/create_role_with_3_options

how come these are going up?

Code quote:

14,CreateRole/create_role_with_1_option
17,CreateRole/create_role_with_2_options
20,CreateRole/create_role_with_3_options
15,CreateRole/create_role_with_no_options

Additional round trip from looking up user_id from username, I'm gonna add caching for this.

[RichardJCai]

Thanks for reviewing!

bors r=ajwerner

[craig]

Canceled.

[RichardJCai]

Trying again
bors r=ajwerner

[craig]

Canceled.

[RichardJCai]

bors r=ajwerner

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)