-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: add role_id, member_id columns to system.role_members #85928
sql: add role_id, member_id columns to system.role_members #85928
Conversation
30b3ab5
to
ac98b30
Compare
Release note: None Release justification: Adding is to system.role_members in same way as system.users, last users table migration for this version. We don't use the IDs to delete or lookup users yet.
ac98b30
to
df2efec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given nothing uses this, do we get benefit from having migrated all the tables? Is it correct that nothing uses it?
Reviewed 6 of 24 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @rhu713)
Yeah we don't use it for reads right now. |
Superseded by #91517 |
sql: add role_id, member_id columns to system.role_members
Release note: None
Release justification: Adding is to system.role_members in same way
as system.users, last users table migration for this version.
We don't use the IDs to delete or lookup users yet.
Last system.users related table migration for 22.2