Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv: remove PrepareRetryableError from the (*kv.Txn) API #86361

Closed
wants to merge 2 commits into from
Closed

kv: remove PrepareRetryableError from the (*kv.Txn) API #86361

wants to merge 2 commits into from

Commits on Aug 18, 2022

  1. kv: update a comment to reflect reality 

    Release justification: Does not change production code, only comments.

Release note: None
    @ajwerner
    ajwerner committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    6bfcc60 View commit details
    Browse the repository at this point in the history

  2. kv: remove PrepareRetryableError from the (*kv.Txn) API 

    This error was never what anybody wanted. It has the odd side-effect
of leaving the transaction usable -- and, worse, the (*kv.Txn).exec loop would
retry but would not restart or replace the transaction if such an error were
returned.

Release justification: important correctness change as part of making the
SQL-over-HTTP APIs work for index recommendations.

Release note: None
    @ajwerner
    ajwerner committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    c475cc7 View commit details
    Browse the repository at this point in the history