multi-tenant: Small cleanup of tenant testing #86877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajstorm
force-pushed
the
ajstorm-tenant-test-knobs
branch
2 times, most recently
from
a28653f
to
acbbffe
Compare
ajstorm
force-pushed
the
ajstorm-tenant-test-knobs
branch
4 times, most recently
from
4ac7c27
to
6641964
Compare
ajstorm
requested review from
srosenberg,
knz and
irfansharif
and removed request for
a team and
srosenberg
|
Hold off on reviewing for now. Looks like someone else beat me to nearly the exact same change. |
ajstorm
force-pushed
the
ajstorm-tenant-test-knobs
branch
from
6641964
to
83c6074
Compare
This commit addresses two problems with tenant testing: - We were mistakenly not passing along the testing knobs from the server to the tenant. - We were printing out the "this test is using a tenant" message before we were guaranteed to be using a tenant. To resolve these issues we now: - Pass along the testing knobs from the server to the tenant with the exception of the Server testing knobs, which mainly apply to the system tenant. - Print out the tenant message only when we're guranteed to be running the test in a tenant. - Also has a small fix to disable tenant testing when testing the span config override. Release justification: Testing only change Release note: None
ajstorm
force-pushed
the
ajstorm-tenant-test-knobs
branch
from
83c6074
to
4a9b145
Compare
|
This should be ready for review now. Adding @stevendanna to reviewers because I'm proposing we roll back his recent change. |
stevendanna
approved these changes
Sep 26, 2022
|
TFTR @stevendanna! bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses two small problems with tenant testing:
tenant.
guaranteed to be using a tenant.
To resolve these issues we now:
in a tenant.
Release justification: Testing only change
Release note: None