storage: add gc benchmarks with multiple range tombstones #88252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
aliher1911
force-pushed
the
range_tombstone_many_test
branch
3 times, most recently
from
3656e30
to
30ec7fb
Compare
aliher1911
force-pushed
the
range_tombstone_many_test
branch
from
30ec7fb
to
f76afca
Compare
aliher1911
force-pushed
the
range_tombstone_many_test
branch
from
f76afca
to
7b3116c
Compare
|
I didn't realize that adding multiple range tombstones will be so disruptive. With 1024 range keys bench will time out preparing the data because insertions become too slow. |
aliher1911
force-pushed
the
range_tombstone_many_test
branch
2 times, most recently
from
417a8d3
to
eec6d5a
Compare
Previously we only had tests that verify GC performance with no range tombstones or with a single range tombstone under all the data. This commit extends the benchmark to have many tombstones interleaving data at different keys. Release note: None
aliher1911
force-pushed
the
range_tombstone_many_test
branch
from
eec6d5a
to
ea2c567
Compare
|
bors r=erikgrinaker |
|
Build failed: |
|
bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only had tests that verify GC performance with no range tombstones or with a single range tombstone under all the data. This commit extends the benchmark to have many tombstones interleaving data at different keys.
Release note: None
Fixes #87417