Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtins: put check_consistency on DistsqlBlocklist #88332

Merged
merged 1 commit into from
Sep 26, 2022
Merged

builtins: put check_consistency on DistsqlBlocklist #88332

merged 1 commit into from
Sep 26, 2022

Conversation

tbg
Copy link
Member

@tbg tbg commented Sep 21, 2022

Fixes #88222.

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg mentioned this pull request Sep 21, 2022
Closed
@tbg tbg requested a review from yuzefovich September 26, 2022 08:41
@tbg tbg marked this pull request as ready for review September 26, 2022 08:41
@tbg tbg requested review from a team September 26, 2022 08:41
erikgrinaker
erikgrinaker approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbg
Copy link
Member Author

tbg commented Sep 26, 2022

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Sep 26, 2022

Build succeeded:

@craig craig bot merged commit db9f943 into cockroachdb:master Sep 26, 2022
@blathers-crl blathers-crl bot mentioned this pull request Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgrinaker erikgrinaker erikgrinaker approved these changes

@yuzefovich yuzefovich Awaiting requested review from yuzefovich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql: evalCtx.ConsistencyChecker inconsistently populated
3 participants
@tbg @cockroach-teamcity @erikgrinaker