Commits on Sep 22, 2022

1. changefeedccl: Do not block on file size based flushes …

   Prior to this change, cloud storage sink trigger
   file sized based flush whenever new row would
   would push the file size beyond configured threshold.
   
   This had the effect of singificantly reducing the throughput
   whenever such event occured -- no additional events could
   be added to cloud storage sink, while the previus flush was
   active.
   
   This is not necessary.  Cloud storage sink can trigger
   file based flushes asynchronously.  The only requirement
   is that if a real, non file based, flush arrives, or if we
   need to emit resolved timestamps, then we must wait for
   all of the active flush requests to complete.
   
   In addition, because every event added to cloud sink has
   associate allocation, which is released when file is written
   out, performing flushes asynchronously is safe with respect
   to memory usage and accounting.
   
   Release note (enterprise change): Changefeeds, using cloud
   storage sink, now have better throughput.
   Release justification: performance fix

   Yevgeniy Miretskiy committed Sep 22, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 81f9932
   • Browse repository at this point

   Copy the full SHA

   81f9932 View commit details

   Browse the repository at this point in the history