Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: workload/mixed-version/schemachanger: re-enable mixed version workload #88407

Closed
wants to merge 3 commits into from
Closed

release-22.2: workload/mixed-version/schemachanger: re-enable mixed version workload #88407

wants to merge 3 commits into from

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 21, 2022 •
edited by fqazi
Loading

Backport 3/3 commits from #87142 on behalf of @fqazi.

/cc @cockroachdb/release

Fixes: #58489 #87477

Previously the mixed version schema changer workload was disabled because of the lack of version gates. These changes will do the following:

  • Start reporting errors on this workload again.
  • Disable trigrams in a mixed version state.
  • Disable the insert part of the workload in a mixed version state (there is an optimizer on 22.1 that can cause some of the queries to fail)

Release justification: low risk only extends test coverage

@fqazi
workload/mixed-version/schemachanger: ensure libGEOS libraries are de…
0405b34 
…ployed

Previously, the schemachanger mixed version workload did not
deploy the libGEOS libraries causing operations to fail. To address,
this patch will update the frontend to upload these binaries.

Release justification: no real risk improves test coverage
Release note: None

merge back
a<pkg>: <short description - lowercase, no final period>

<what was there before: Previously, ...>
<why it needed to change: This was inadequate because ...>
<what you did about it: To address this, this patch ...>
@fqazi
workload/schemachanger: disable trigram operations in a mixed version…
e8b67cc 
… state

Previously, the schema changer workload in a mixed version state
attempted to use trigram indexes against 22.1, which is unsupported.
This patch adds code to detect a mixed version state and expects
the appropriate error when this occurs.

Release justification: no risk improves test coverage
Release note: None
@fqazi
workload/schemachange: disable inserts when in 22.1 mixed version state
94eda53 
Previously, if we ran in a mixed version state with the schema changer
workload we could run into an optimizer bug (#80820). To address this,
this patch in a mixed version workload disables the insert portion of
the workload.

Release justification: improves test coverage by enabling the mixed
version test
Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-87142 branch from df0741a to 94eda53 Compare September 21, 2022 21:14
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 21, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 21, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@fqazi fqazi closed this Sep 23, 2022
@mgartner mgartner deleted the blathers/backport-release-22.2-87142 branch May 23, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fqazi fqazi Awaiting requested review from fqazi

@Xiang-Gu Xiang-Gu Awaiting requested review from Xiang-Gu

Assignees

@fqazi fqazi

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cockroach-teamcity @fqazi