Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keys: mark 49 as reserved #88477

Merged
merged 1 commit into from
Sep 22, 2022
Merged

keys: mark 49 as reserved #88477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/keys/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,8 +467,20 @@ const (
SQLInstancesTableID = 46
SpanConfigurationsTableID = 47
RoleIDSequenceID = 48

// reservedSystemTableID is a sentinel constant to reserve the use of the
// last remaining constant reserved descriptor ID. In 22.1, we added support
// for creating system tables with dynamically allocated IDs. Use of this ID
// should be well motivated. There are cases where having a constant ID can
// dramatically simplify cluster bootstrap. Any table which is not going to
// be used quite early in the server startup process should not need a
// constant ID. Note that there are some values we could reclaim, like 9 and
// 10, but let's not go there unless we need to.
reservedSystemTableID = 49
)

var _ = reservedSystemTableID // defeat the unused linter

// CommentType the type of the schema object on which a comment has been
// applied.
type CommentType int
Expand Down