ui: insights overview rename 'execution id' to 'latest execution id' #88509
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @j82w and @maryliag)
pkg/ui/workspaces/cluster-ui/src/insights/workloadInsights/util/insightsColumns.tsx line 80 at r1 (raw file):
); }, executionID: (execType: InsightExecEnum) => {
are we using this anywhere now that you replaced with latest?
|
Previously, maryliag (Marylia Gutierrez) wrote…
Yes, it's being used in the details page. |
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/insights/workloadInsights/util/insightsColumns.tsx line 82 at r1 (raw file):
executionID: (execType: InsightExecEnum) => { return makeToolTip( <p>The execution ID of the execution with the {execType} fingerprint.</p>,
nit: The ID of the execution with the {execType} fingerprint
closes #88456 Release justification: Category 2: Bug fixes and low-risk updates to new functionality Release note: (ui change): Rename insights overview table column 'execution id' to 'latest execution id'. This will help avoid confusion since the ui only shows the latest id per fingerprint.
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
The insights only shows the latest execution id per a fingerprint. Renaming the column will avoid confusion where user might expect multiple execution ids for the same fingerprint.
After showing the new column name.
closes #88456
Release justification: Category 2: Bug fixes and
low-risk updates to new functionality
Release note: (ui change): Rename insights overview table column 'execution id' to 'latest execution id'. This will help avoid confusion since the ui only shows the latest id per fingerprint.