Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.1: roachtest: use highmem instances for some tests #88553

Merged
merged 3 commits into from
Sep 26, 2022
Merged

release-22.1: roachtest: use highmem instances for some tests #88553

merged 3 commits into from
Sep 26, 2022

Conversation

erikgrinaker
Copy link
Contributor

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release justification: deflakes tests.

@erikgrinaker
roachtest: use n1-standard for 16-core GCE machines
901ae27 
Roachtest used `n1-highcpu` machines at 16 cores and beyond. However,
this causes a memory cliff, because a `n1-standard-8` machine has ~30 GB
memory (3.75 GB per core), but a `n1-highcpu-16` machine only has 14 GB
memory (0.9 GB per core).

This patch makes 16-core machines use `n1-standard` as well, with 60 GB
memory, and only switches to `n1-highcpu` at 32 cores (with 29 GB
memory).

Release note: None
@erikgrinaker
roachtest: add HighMem option
45e0c7c 
This patch adds a `HighMem` cluster spec option, which will use machine
types with increased memory. There are no changes to existing machine
types.

Release note: None
@erikgrinaker
roachtest: use highmem instances for some tests
054e858 
The following tests have been seen to OOM occasionally. Since a root
cause fix isn't planned for the near term, this serves to deflake the
tests.

* `tpccbench/nodes=9/cpu=4/multi-region`
* `restore2TB/*`

Release note: None
@erikgrinaker erikgrinaker requested a review from a team as a code owner September 23, 2022 08:47
@erikgrinaker erikgrinaker self-assigned this Sep 23, 2022
@blathers-crl
Copy link

blathers-crl bot commented Sep 23, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker merged commit ae34e9b into cockroachdb:release-22.1 Sep 26, 2022
This was referenced Sep 26, 2022
Closed
Closed
@erikgrinaker erikgrinaker deleted the backport22.1-88346-88444 branch December 28, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

@srosenberg srosenberg Awaiting requested review from srosenberg

Assignees

@erikgrinaker erikgrinaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikgrinaker @cockroach-teamcity @tbg