release-22.2: backupccl: elide expensive ShowCreate call in SHOW BACKUP #88711
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #88293.
/cc @cockroachdb/release
In #88376 we see the call to
ShowCreate
taking ~all the time on a cluster with2.5K empty tables. In all cases except
SHOW BACKUP SCHEMAS
we do notneed to construct the SQL representation of the table's schema. This
results in a marked improvement in the performance of
SHOW BACKUP
as can be seen in #88376 (comment).
Fixes: #88376
Release note (performance improvement):
SHOW BACKUP
on a backup containingseveral table descriptors is now more performant
Release justification: low risk performance improvement required for the use of schedules in CockroachCloud