Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: backupccl: elide expensive ShowCreate call in SHOW BACKUP #88711

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

adityamaru
Copy link
Contributor

@adityamaru adityamaru commented Sep 26, 2022

Backport 1/1 commits from #88293.

/cc @cockroachdb/release


In #88376 we see the call to ShowCreate taking ~all the time on a cluster with
2.5K empty tables. In all cases except SHOW BACKUP SCHEMAS we do not
need to construct the SQL representation of the table's schema. This
results in a marked improvement in the performance of SHOW BACKUP
as can be seen in #88376 (comment).

Fixes: #88376

Release note (performance improvement): SHOW BACKUP on a backup containing
several table descriptors is now more performant

Release justification: low risk performance improvement required for the use of schedules in CockroachCloud

In cockroachdb#88376 we see this call taking ~all the time on a cluster with
2.5K empty tables. In all cases except `SHOW BACKUP SCHEMAS` we do not
need to construct the SQL representation of the table's schema. This
results in a marked improvement in the performance of `SHOW BACKUP`
as can be seen in cockroachdb#88376 (comment).

Fixes: cockroachdb#88376

Release note (performance improvement): `SHOW BACKUP` on a backup containing
several table descriptors is now more performant
@adityamaru adityamaru requested a review from a team as a code owner September 26, 2022 13:55
@adityamaru adityamaru requested a review from a team September 26, 2022 13:55
@adityamaru adityamaru requested a review from a team as a code owner September 26, 2022 13:55
@blathers-crl
Copy link

blathers-crl bot commented Sep 26, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@adityamaru adityamaru removed the request for review from a team September 26, 2022 13:55
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
Copy link
Contributor Author

blathers backport 22.1

@blathers-crl
Copy link

blathers-crl bot commented Dec 6, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from fdf45ed to blathers/backport-release-22.1-88711: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants