Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: opt: add tests for FK delete cascade fast-path with UDF #89127

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Sep 30, 2022

Backport 1/1 commits from #88933 on behalf of @mgartner.

/cc @cockroachdb/release


The FK delete cascade fast-path remaps the DELETE filter into a filter on child table, avoiding buffering the parent's deleted rows like in the non-fast-path plan. It is possible to plan this fast-path if the filters contain UDF invocations, as long as they are immutable or stable. (Of course, if the user creates a UDF with mislabeled volatility, data corruption is possible. To mitigate this and other corruption from mislabeled UDF volatility in the future, we're considering performing some analysis during CREATE FUNCTION to prevent users from incorrectly assigning volatility.)

This commit adds tests for FK delete cascades with UDFs and removes an unnecessary TODO.

Release note: None


Release justification: Test-only change.

The FK delete cascade fast-path remaps the `DELETE` filter into a filter
on child table, avoiding buffering the parent's deleted rows like in the
non-fast-path plan. It is possible to plan this fast-path if the filters
contain UDF invocations, as long as they are immutable or stable. (Of
course, if the user creates a UDF with mislabeled volatility, data
corruption is possible. To mitigate this and other corruption from
mislabeled UDF volatility in the future, we're considering performing
some analysis during `CREATE FUNCTION` to prevent users from incorrectly
assigning volatility.)

This commit adds tests for FK delete cascades with UDFs and removes an
unnecessary TODO.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner September 30, 2022 22:12
@blathers-crl
Copy link
Author

blathers-crl bot commented Sep 30, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Sep 30, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rytaft)

@mgartner mgartner merged commit 85c2180 into release-22.2 Oct 7, 2022
@mgartner mgartner deleted the blathers/backport-release-22.2-88933 branch October 7, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants