acceptance: deflake TestDockerCLI/test_txn_prompt
#91249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That test would sometimes fail because of the semantics of `expect` and `send` when the expected string was previously written using `send`. When `expect` is called, the buffer looked at includes content previously sent using `send`. This means that if one runs `send "foo"; expect foo`, the `expect` call will match instataneously even if the program's output after the send does not contain `foo`. In the case of the test fixed here, we are supposed to expect for the new prompt to be printed after setting it with `\set prompt1`. In order to properly check whether the prompt changed, this PR changes the prompt `expect` call to use a regular expression that matches the new prompt only if it sits in the beginning of a line. Prior to this commit, since the `expect` call would return immediately, there was a chance the `send "SET DATABASE"` command could run before the cockroach CLI had the chance to print the new prompt, leading to the following error: ``` abcdefaultdbdef \set prompt1 woo SET database woo -> .221103 18:13:35.539667600 EXPECT TEST: TIMEOUT WAITING FOR " -> " non-zero exit code: 1 ``` Epic: None Release note: None
|
This change is |
|
Example of a recent flake: https://teamcity.cockroachdb.com/viewLog.html?buildId=7303304&buildTypeId=Cockroach_BazelEssentialCi |
|
bors r=rafiss TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That test would sometimes fail because of the semantics of
expectandsendwhen the expected string was previously written usingsend.When
expectis called, the buffer looked at includes content previously sent usingsend. This means that if one runssend "foo"; expect foo, theexpectcall will match instataneously even if the program's output after the send does not containfoo.In the case of the test fixed here, we are supposed to expect for the new prompt to be printed after setting it with
\set prompt1. In order to properly check whether the prompt changed, this PR changes the promptexpectcall to use a regular expression that matches the new prompt only if it sits in the beginning of a line.Prior to this commit, since the
expectcall would return immediately, there was a chance thesend "SET DATABASE"command could run before the cockroach CLI had the chance to print the new prompt, leading to the following error:Epic: None
Release note: None