Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multitenant: add admin function RangeIterator failed to seek test cases #91436

Merged
merged 1 commit into from
Nov 8, 2022
Merged

multitenant: add admin function RangeIterator failed to seek test cases #91436

merged 1 commit into from
Nov 8, 2022

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Nov 7, 2022

refs #91434

This change adds test cases for admin functions (see #91434) that fail because of a RangeIterator failed to seek error once the multitenant check is bypassed. This needs to be addressed before those admin functions can be supported for secondary tenants.

Release note: None

@ecwall ecwall requested a review from knz November 7, 2022 20:32
@ecwall ecwall requested a review from a team as a code owner November 7, 2022 20:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ecwall ecwall requested a review from rafiss November 7, 2022 21:03
…ases

See also #91434

This change adds test cases for admin functions (see #91434) that fail because
of a `RangeIterator failed to seek` error once the multitenant check is
bypassed. This needs to be addressed before those admin functions can be
supported for secondary tenants.

Release note: None
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not so familiar with this functionality, but the testing changes lgtm

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @knz)

@ecwall
Copy link
Contributor Author

ecwall commented Nov 8, 2022

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Nov 8, 2022

Build succeeded:

@craig craig bot merged commit 2e90394 into cockroachdb:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants