Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: kvserver: return DeprecatedLeaseHolder field in NLHEs #91525

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 8, 2022

Backport 1/1 commits from #91515 on behalf of @arulajmani.

/cc @cockroachdb/release


v22.1 binaries assume that the leaseholder is unknown when logging NLHE errors if the (Deprecated)LeaseHolder field is unset -- regardless of if the Lease is set or not. We broke this logging in 0402f47 (for mixed version clusters) when we stopped shipping back leaseholder information (in favour of only shipping lease information) on NLHEs. This patch fixes this by populating the (Deprecated)LeaseHolder field when constructing NLHEs.

Release note: None


Release justification: bug fix

v22.1 binaries assume that the leaseholder is unknown when logging
NLHE errors if the (Deprecated)LeaseHolder field is unset -- regardless
of if the Lease is set or not. We broke this logging in 0402f47
(for mixed version clusters) when we stopped shipping back leaseholder
information (in favour of only shipping lease information) on NLHEs.
This patch fixes this by populating the (Deprecated)LeaseHolder field
when constructing NLHEs.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 8, 2022 17:57
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-91515 branch from af14e96 to 19d93a5 Compare November 8, 2022 17:57
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 8, 2022
@blathers-crl
Copy link
Author

blathers-crl bot commented Nov 8, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@arulajmani arulajmani merged commit 96067b4 into release-22.2 Nov 9, 2022
@arulajmani arulajmani deleted the blathers/backport-release-22.2-91515 branch November 9, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants