kvserver: move checkForcedErr to kvserverbase #91734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is called from below-raft, so if we hope to apply log entries offline in a contained context, we want to be able to call this without pulling in the `kvserver` package. Epic: CRDB-220 Release note: None
|
This change is |
tbg
force-pushed
the
extract-forced-err
branch
from
a392e5d
to
11e648f
Compare
These are referenced from checkForcedErr, and if we are to apply proposals via a smaller library we can't have them live in `kvserver` due to import conflicts. The move is mechanical. I also threw in a mechanical rename since the previous names weren't very descriptive. Release note: None
tbg
force-pushed
the
extract-forced-err
branch
from
11e648f
to
4c3398c
Compare
pav-kv
approved these changes
Nov 11, 2022
|
The PR name and message seems to have picked up only the last commit. Try to write overviews? |
This is a prereq to making log application stand-alone, since applying entries means calling this method to determine whether to apply an empty entry instead. Touches cockroachdb#75729. Epic: CRDB-220 Release note: None
tbg
force-pushed
the
extract-forced-err
branch
from
4c3398c
to
08c83d4
Compare
|
Updated PR message as well. |
|
bors r=pavelkalinnikov TFTR! |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prereq to making log application stand-alone, since applying
entries means calling this method to determine whether to apply an
empty entry instead.
This necessitated moving the constructor for NotLeaseholderError where it belongs (roachpb) and
moving proposal evaluation reasons to somewhere else (I chose kvserverpb). While I was there I
also renamed their type to better reflect that these are command rejections.
Touches #75729.
Epic: CRDB-220
Release note: None