Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: fix typo when saving artifacts in schemachange_random_load #91772

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

renatolabs
Copy link
Contributor

@renatolabs renatolabs commented Nov 11, 2022

Epic: None
Release note: None

@renatolabs renatolabs requested a review from a team November 11, 2022 20:44
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @renatolabs)

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically ndjson is probably a better suffix

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @renatolabs)

@renatolabs
Copy link
Contributor Author

bors r=postamar,ajwerner

@craig
Copy link
Contributor

craig bot commented Nov 11, 2022

Build succeeded:

@craig craig bot merged commit 5c76966 into cockroachdb:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants