Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs: refresh job details before removing protected timestamps #92586

Merged
merged 1 commit into from
Nov 28, 2022

Commits on Nov 28, 2022

  1. jobs: refresh job details before removing protected timestamps

    Fixes: cockroachdb#92493
    
    Previously, we added the protected timestamps manager into the jobs
    frame work, which made it easier to automatically add and remove
    protected timestamps for jobs. Unfortunately, the Unprotect API
    when invoked from a clean up function never properly refreshed
    the job. Which could lead to a race condition trying to remove
    protected timestamps for schema changes. To address this, the
    Unprotect function will take advantage of the job update function
    to confirm that a refreshed copy does have protected timestamps
    set.
    
    Release note: None
    fqazi committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    02867ed View commit details
    Browse the repository at this point in the history