sql: simplify user id querying for GRANT ROLE #96205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
ZhouXing19
approved these changes
Jan 30, 2023
|
TFTR! bors r=ZhouXing19 |
This patch inlines the querying of the role and member user ids within the GRANT ROLE logic instead of making separate internal executor queries. Release note: None
andyyang890
force-pushed
the
simplify_role_members
branch
from
88f284f
to
f833228
Compare
|
Canceled. |
|
removed some unnecessary quotation marks bors r=ZhouXing19 |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch inlines the querying of the role and member user ids
within the GRANT ROLE logic instead of making separate internal
executor queries.
Part of #87079
Release note: None