changefeedccl: Rename and remove CDC functions

[miretskiy]

This PR renames and removes CDC specific functions, while maintaining backward compatability.

• cdc_is_delete() function removed. It is replaced
  with event_op() function which returns a string describing
  the type of event. If the changefeed is running with diff
  option, then this function returns insert, update, or
  delete. If changefeed is running without the diff option,
  we can't tell an update from insert, so this function returns
  upsert or delete.
• cdc_mvcc_timestamp() function removed. This information can be accessed
  via cockroach standard system column crdb_internal_mvcc_timestamp.
  The same timestamp column is avaiable in the previous row state
  (cdc_prev).crdb_internal_mvcc_timestamp
• cdc_updated_timestamp() function renamed as event_schema_timestamp()

Fixes #92482
Epic: CRDB-17161

Release note (enterprise change): Deprecate and replace some of the changefeed specific functions made available in preview mode in 22.2
release. While these functions are deprecated, old changefeed
transformations should continue to function properly.
Customers are encouraged to closely monitor their changefeeds
created during upgrade. While effort was made to maintain backward
compatibility, the updated changefeed transformation may produce
slightly different output (different column names, etc).

[cockroach-teamcity]

This change is 

[jayshrivastava]

Small comments. Looks good otherwise.

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @HonoreDB and @miretskiy)

---

-- commits line 5 at r1:
Since they were released in preview mode, it should be fine to break them if you want. Up to you.

Code quote:

  This PR renames and removes CDC specific functions,
  while maintaining backward compatability.

---

-- commits line 5 at r1:
typo: "compatibility"

---

-- commits line 9 at r1:
typo: corresponding

---

-- commits line 14 at r1:
typo: available

---

pkg/ccl/changefeedccl/cdceval/expr_eval.go line 186 at r1 (raw file):

	// Setup context.
	if err := e.setupContextForRow(ctx, updatedRow, prevRow.IsDeleted()); err != nil {

I think there's some subtitles here. For example, isNew will always be true when you don't use with_diff because the prevRow is always uninitialized (at least I think that's the case from reading the code). IMO that's fine, but unexpected. Maybe that's something worth mentioning in a comment or in the event_op function Info field in pkg/ccl/changefeedccl/cdceval/functions.go

[miretskiy]

I think there's some subtitles here. For example, isNew will always be true when you don't use with_diff because the prevRow is always uninitialized (at least I think that's the case from reading the code). IMO that's fine, but unexpected.

This is an excellent point, @jayshrivastava
I need to think a bit more on this; I think we should force withDiff if you use event_op (much like we do w/ cdc_prev).
But, as you say, this might be a simple matter of documenting because forcing withDiff is not w/out costs.

[miretskiy]

@jayshrivastava -- just pushed an updated version; I changed this function so that when running without diff,
only upsert or delete is returned since we can't tell insert from an update.
Thanks for bringing this up.

[miretskiy]

@jayshrivastava let me know if I still have your vote after the most recent changes.

[jayshrivastava]

LGTM. There are still a couple typos.

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @HonoreDB and @miretskiy)

---

-- commits line 5 at r1:

Previously, jayshrivastava (Jayant) wrote…

typo: "compatibility"

!

---

-- commits line 14 at r1:

Previously, jayshrivastava (Jayant) wrote…

typo: available

!

[miretskiy]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @HonoreDB and @jayshrivastava)

---

-- commits line 5 at r1:

Previously, jayshrivastava (Jayant) wrote…

Since they were released in preview mode, it should be fine to break them if you want. Up to you.

Done.

---

pkg/ccl/changefeedccl/cdceval/expr_eval.go line 186 at r1 (raw file):

Previously, jayshrivastava (Jayant) wrote…

I think there's some subtitles here. For example, isNew will always be true when you don't use with_diff because the prevRow is always uninitialized (at least I think that's the case from reading the code). IMO that's fine, but unexpected. Maybe that's something worth mentioning in a comment or in the event_op function Info field in pkg/ccl/changefeedccl/cdceval/functions.go

Done.

[miretskiy]

bors r+

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

Build failed (retrying...):

• Bazel Essential CI (Cockroach)

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)