Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: implement function OID reference #96406

Conversation

chengxiong-ruan
Copy link
Contributor

This commit implements @F OID references syntax of functions. With this change, functions can be called with oid numerical representation. For example SELECT @F('helloworld'). The intention of this syntax is only for internal serialization of references to UDFs. But it's general enough for builtin funtions as well.

Fixes: #83231

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@chengxiong-ruan chengxiong-ruan force-pushed the implement-function-reference-by-oid branch from 33580fe to 7ed09a6 Compare February 2, 2023 05:18
This commit implements `@F` OID references syntax of functions.
With this change, functions can be called with oid numerical
representation. For example `SELECT @f('helloworld')`.
The intention of this syntax is only for internal serialization
of references to UDFs. But it's general enough for builtin
funtions as well.

Fixes: cockroachdb#83231

Release note: None
@chengxiong-ruan chengxiong-ruan force-pushed the implement-function-reference-by-oid branch from 7ed09a6 to ad33f14 Compare February 2, 2023 14:34
@chengxiong-ruan chengxiong-ruan marked this pull request as ready for review February 2, 2023 14:37
@chengxiong-ruan chengxiong-ruan requested a review from a team as a code owner February 2, 2023 14:37
@chengxiong-ruan chengxiong-ruan requested review from a team February 2, 2023 14:37
@chengxiong-ruan chengxiong-ruan requested review from a team as code owners February 2, 2023 14:37
@chengxiong-ruan chengxiong-ruan requested review from miretskiy and removed request for a team February 2, 2023 14:37
@chengxiong-ruan
Copy link
Contributor Author

hrm. this is not quite working...@F syntax would fool the table@index_name when index_name starts with F

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UDF: Support Function OIDs and Function reference with OIDs in expressions
2 participants