Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: use descs.Txn for schemachanger.txn #96598

Merged

Conversation

ZhouXing19
Copy link
Collaborator

@ZhouXing19 ZhouXing19 commented Feb 6, 2023

This commit includes just mechanical changes to use the new internal executor interface introduced by #93218 for schemachanger.txn().

informs #91004
Release Note: None

@blathers-crl
Copy link

blathers-crl bot commented Feb 6, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

This commit is to use the new internal executor interface introduced by cockroachdb#93218
for `schemachanger.txn()`.

informs cockroachdb#91004
Release Note: None
@ZhouXing19 ZhouXing19 force-pushed the schemachanger-new-internal-executor branch from a121525 to 8e149bf Compare February 6, 2023 04:35
@ZhouXing19 ZhouXing19 marked this pull request as ready for review February 6, 2023 16:14
@ZhouXing19 ZhouXing19 requested review from a team as code owners February 6, 2023 16:14
@ZhouXing19 ZhouXing19 requested review from a team, benbardin and ajwerner and removed request for a team February 6, 2023 16:14
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks!

Can we get rid of descs.FromTxn? Seems close to going away by plumbing descs.Txn where needed. Leave that for a separate PR.

@ZhouXing19
Copy link
Collaborator Author

TFTR!

Can we get rid of descs.FromTxn?

I think so.

bors r=ajwerner

@craig
Copy link
Contributor

craig bot commented Feb 6, 2023

Build succeeded:

@craig craig bot merged commit b031933 into cockroachdb:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants