Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlsmith: disable crdb_internal.hide_sql_constants #96741

Merged
merged 1 commit into from
Feb 8, 2023
Merged

sqlsmith: disable crdb_internal.hide_sql_constants #96741

merged 1 commit into from
Feb 8, 2023

Conversation

rharding6373
Copy link
Collaborator

@rharding6373 rharding6373 commented Feb 7, 2023 •
edited
Loading

Informs: #96555
Epic: None

@rharding6373 rharding6373 requested a review from a team as a code owner February 7, 2023 20:04
@cockroach-teamcity
Copy link
Member

This change is Reviewable

yuzefovich
yuzefovich approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @michae2 and @rharding6373)

-- commits line 4 at r1:
nit: need to use # to link to the github issue (i.e. for this PR to show up as a mention on #96555).

michae2
michae2 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (and 1 stale) (waiting on @rharding6373)

@rharding6373
Copy link
Collaborator Author

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 7, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 8, 2023

Build succeeded:

@craig craig bot merged commit 60c6293 into cockroachdb:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michae2 michae2 michae2 approved these changes

@yuzefovich yuzefovich yuzefovich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rharding6373 @cockroach-teamcity @yuzefovich @michae2