Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload/schemachange: skip tsquery/tsvector types in mixed version envs #96954

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Feb 10, 2023

Previously, the randomized schema change workload in a mixed version environment attempted to create tables with the tsvector/tsquery types. This could lead to syntax errors on older nodes that do not know of this. This patch, avoids using these types until the version of the cluster hits 23.1.

Epic: none
Release note: None

@fqazi fqazi requested a review from a team February 10, 2023 16:31
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Fixes: cockroachdb#96489

Previously, the randomized schema change workload in a mixed
version environment attempted to create tables with the tsvector/tsquery
types. This could lead to syntax errors on older nodes that do not
know of this. This patch, avoids using these types until the version
of the cluster hits 23.1.

Epic: none
Release note: None
@fqazi fqazi marked this pull request as ready for review February 10, 2023 19:05
@fqazi fqazi requested a review from a team as a code owner February 10, 2023 19:05
@fqazi fqazi requested review from smg260 and renatolabs and removed request for a team February 10, 2023 19:05
@fqazi
Copy link
Collaborator Author

fqazi commented Feb 13, 2023

bors r+

@fqazi
Copy link
Collaborator Author

fqazi commented Feb 13, 2023

@chengxiong-ruan TFTR!

@craig
Copy link
Contributor

craig bot commented Feb 13, 2023

Build succeeded:

@craig craig bot merged commit 47331b1 into cockroachdb:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants