-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: tenant-gate transaction insights, change selection order of workload insights #97256
ui: tenant-gate transaction insights, change selection order of workload insights #97256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @kevin-v-ngo)
09f1e61
to
992f01b
Compare
…oad insights Related to cockroachdb#96353, cockroachdb#92936. This commit hides the dropdown to switch workload insights from statement insights to transaction insights on tenants. When cockroachdb#96353 is resolved, we can re-enable transaction insights for tenant clusters. The commit also switches the order of workload insights, to show statement insights first (see cockroachdb#92936). Release note: None
992f01b
to
508a9c2
Compare
The GH CI failure appears to be unrelated to the changes in this PR. |
bors r+ |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 508a9c2 to blathers/backport-release-22.2-97256: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Related to #96353, #92936.
This commit hides the dropdown to switch workload insights from statement insights to transaction insights on tenants. When #96353 is resolved, we can re-enable transaction insights for tenant clusters.
The commit also switches the order of workload insights, to show statement insights first (see #92936).
@gemma-shay We should add a note on the Insights docs and/or the serverless docs that Transaction Insights aren't available on serverless.
Release note: None
Epic: None