Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: tenant-gate transaction insights, change selection order of workload insights #97256

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

ericharmeling
Copy link
Contributor

@ericharmeling ericharmeling commented Feb 16, 2023

Related to #96353, #92936.

This commit hides the dropdown to switch workload insights from statement insights to transaction insights on tenants. When #96353 is resolved, we can re-enable transaction insights for tenant clusters.

The commit also switches the order of workload insights, to show statement insights first (see #92936).

@gemma-shay We should add a note on the Insights docs and/or the serverless docs that Transaction Insights aren't available on serverless.

Release note: None

Epic: None

@ericharmeling ericharmeling requested review from maryliag, kevin-v-ngo and a team February 16, 2023 19:04
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!
:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @kevin-v-ngo)

@ericharmeling ericharmeling force-pushed the tenant-gate-txn-insights branch from 09f1e61 to 992f01b Compare February 16, 2023 22:09
…oad insights

Related to cockroachdb#96353, cockroachdb#92936.

This commit hides the dropdown to switch workload insights from
statement insights to transaction insights on tenants. When cockroachdb#96353
is resolved, we can re-enable transaction insights for tenant
clusters.

The commit also switches the order of workload insights, to show
statement insights first (see cockroachdb#92936).

Release note: None
@ericharmeling ericharmeling force-pushed the tenant-gate-txn-insights branch from 992f01b to 508a9c2 Compare February 17, 2023 21:30
@ericharmeling
Copy link
Contributor Author

The GH CI failure appears to be unrelated to the changes in this PR.

@ericharmeling
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Feb 18, 2023

Build succeeded:

@craig craig bot merged commit c95bef0 into cockroachdb:master Feb 18, 2023
@blathers-crl
Copy link

blathers-crl bot commented Feb 18, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 508a9c2 to blathers/backport-release-22.2-97256: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@ericharmeling
Copy link
Contributor Author

#96353 is resolved in 23.1, so we can revert these changes (but not #97329, as #97467 was not backported).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants