jobs,backupccl: Update metrics poller to handle schedule PTS records #97651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
adityamaru
approved these changes
Mar 13, 2023
pkg/jobs/schedule_metrics.go
Outdated
| @@ -114,3 +132,23 @@ func MakeExecutorMetrics(name string) ExecutorMetrics { | |||
| }), | |||
| } | |||
| } | |||
|
|
|||
| // MakeExecutorPTSMetricsS creates PTS metrics. | |||
| func MakeExecutorPTSMetricsS(name string) ExecutorPTSMetrics { | |||
There was a problem hiding this comment.
nit: extra S at the end of method name?
There was a problem hiding this comment.
It's a very SSSpecial name :)
Thanks. Fixed.
Update metrics poller to keep track of PTS records held by scheduled jobs. Epic: CRDB-21953 Release note: None
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
bors r+ |
|
Already running a review |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update metrics poller to keep track of PTS records held by scheduled jobs.
Epic: CRDB-21953
Release note: None