Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: remove current version from declarative-print-rules test #97811

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Feb 28, 2023

Previously, when the test for declarative-print-rules was added it displayed the current version. This could be annoying during development as the version gets bumped up during the development of a release. To address this, this patch masks out the version number with the word latest.

Epic: none

Release note: None

Previously, when the test for declarative-print-rules was
added it displayed the current version. This could be annoying
during development as the version gets bumped up during
the development of a release. To address this, this
patch masks out the version number with the word latest.

Epic: none

Release note: None
@fqazi fqazi requested a review from a team as a code owner February 28, 2023 20:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fqazi
Copy link
Collaborator Author

fqazi commented Feb 28, 2023

bors r+

@fqazi
Copy link
Collaborator Author

fqazi commented Feb 28, 2023

@chengxiong-ruan TFTR

@craig
Copy link
Contributor

craig bot commented Feb 28, 2023

Build succeeded:

@craig craig bot merged commit 998b030 into cockroachdb:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants