sqlsmith: bring back hide_sql_constants #97831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
rharding6373
approved these changes
Mar 2, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
Now that cockroachdb#96555 and cockroachdb#97830 are fixed, add `hide_sql_constants` back to sqlsmith. Also add some missing spaces to the info strings. Epic: None Release note: None
michae2
force-pushed
the
hide_sql_constants
branch
from
9818625
to
247abc4
Compare
michae2
changed the title
|
bors r=rharding6373 |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #96555 and #97830 are fixed, add
hide_sql_constantsback to sqlsmith. Also add some missing spaces to the info strings.Epic: None
Release note: None