dashboards: add replica cpu to repl dashboard #98270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kvoli
force-pushed
the
230308.rebalancing-cpu-dash
branch
3 times, most recently
from
5e1d842
to
30b6da5
Compare
kvoli
force-pushed
the
230308.rebalancing-cpu-dash
branch
2 times, most recently
from
c43d154
to
e144cb7
Compare
xinhaoz
approved these changes
Mar 9, 2023
| rebalancing decisions.`} | ||
| > | ||
| <Axis units={AxisUnits.Duration} label="CPU time"> | ||
| {_.map(nodeIDs, nid => ( |
There was a problem hiding this comment.
nit: prefer native array map over lodash's map
There was a problem hiding this comment.
Updated to use native map. I also pushed a preceding commit that replaces _.map with the native array map for the other graphs in replication.tsx.
kvoli
force-pushed
the
230308.rebalancing-cpu-dash
branch
from
e144cb7
to
972570a
Compare
This commit updates the replication dashboard to use the native javascript array map function, instead of lodash map. Release note: None
The avg QPS graph on the replication graph previously described the metric as "Exponentially weighted average", however this is not true. This commit updates the description to just be "moving average" which is accurate. Note that follow the workload does use an exponentially weighted value, however the metric in the dashboard is not the same. This commit also updates the graph header to include Replica in the title: "Average Replica Queries per Node". QPS is specific to replicas. This is already mentioned in the description. Release note (ui change): The description of the average QPS graph in the replication metrics dashboard no longer claims the average is exponentially weighted.
In cockroachdb#96127 we added the option to load balance replica CPU instead of QPS across stores in a cluster. It is desirable to view the signal being controlled for rebalancing in the replication dashboard, similar to QPS. This commit adds the `rebalancing.cpunanospersecond` metric to the replication metrics dashboard. Resolves: cockroachdb#98109 Release note (ui change): `rebalancing.cpunanospersecond` is now included in the replication metrics dashboard.
kvoli
force-pushed
the
230308.rebalancing-cpu-dash
branch
from
972570a
to
646d5e6
Compare
|
TYFTR bors r=xinhaoz |
|
Build succeeded: |
This was referenced Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #96127 we added the option to load balance replica CPU instead of QPS across
stores in a cluster. It is desirable to view the signal being controlled for
rebalancing in the replication dashboard, similar to QPS.
This pr adds the
rebalancing.cpunanospersecondmetric to the replicationmetrics dashboard.
The avg QPS graph on the replication graph previously described the metric as
"Exponentially weighted average", however this is not true.
This pr updates the description to just be "moving average" which is accurate.
Note that follow the workload does use an exponentially weighted value, however
the metric in the dashboard is not the same.
This pr also updates the graph header to include Replica in the title: "Average
Replica Queries per Node". QPS is specific to replicas. This is already
mentioned in the description.
Resolves: #98109