Commits on Mar 9, 2023

1. storage: mvccExportToWriter should return always buffered range keys …

   In cockroachdb#96691, we changed the return type of mvccExportToWriter such that
   it now indicates when a CPU limit has been reached. As part of that
   change, when the CPU limit was reached, we would immedately `return`
   rather than `break`ing out of the loop. This introduced a bug, since
   the code after the loop that the `break` was taking us to is
   important. Namely, we may have previously buffered range keys that we
   need to write into our response still. By replacing the break with a
   return, these range keys were lost.
   
   The end-user impact of this is that a BACKUP that _ought_ to have
   included range keys (such as a backup of a table with a rolled back
   IMPORT) would not include those range keys and thus would end up
   resurecting deleted keys upon restore.
   
   This PR brings back the `break` and adds a test that covers exporting
   with range keys under CPU exhaustion.
   
   This bug only ever existed on master.
   
   Informs cockroachdb#97694
   
   Epic: none
   
   Release note: None

   

   stevendanna committed Mar 9, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 74c8915
   • Browse repository at this point

   Copy the full SHA

   74c8915 View commit details

   Browse the repository at this point in the history