-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jobs,upgrades: add migration to backfill job_info table #98464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first two commits are #97218 |
dt
reviewed
Mar 12, 2023
pkg/upgrade/upgrades/backfill_jobs_info_table_migration_test.go
Outdated
Show resolved
Hide resolved
adityamaru
force-pushed
the
backfill-jobs-table
branch
from
March 13, 2023 13:21
77672bb
to
de6b093
Compare
adityamaru
changed the title
jobs.upgrades: add migration to backfill job_info table
jobs,upgrades: add migration to backfill job_info table
Mar 13, 2023
adityamaru
force-pushed
the
backfill-jobs-table
branch
from
March 14, 2023 13:59
de6b093
to
b1b019f
Compare
dt
approved these changes
Mar 14, 2023
This change adds a migration and corresponding cluster version after which every job entry in the system.jobs table will have its Payload and Progress written to two rows in the system.job_info table. Informs: cockroachdb#97762 Release note: None
adityamaru
force-pushed
the
backfill-jobs-table
branch
from
March 14, 2023 15:15
b1b019f
to
08f0288
Compare
TFTR! bors r=dt |
Build failed (retrying...): |
Build failed (retrying...): |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a migration and corresponding cluster version
after which every job entry in the system.jobs table will have its
Payload and Progress written to two rows in the system.job_info table.
Informs: #97762
Release note: None