Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changefeedccl: enable TestChangefeedPropagatesTerminalError #98472

Conversation

samiskin
Copy link
Contributor

Fixes: #95057

The test TestChangefeedPropagatesTerminalError no longer seems to flake after running it under stress on a GCE worker for a while, so this change re-enables it.

Release note: None

Fixes: cockroachdb#95057

The test TestChangefeedPropagatesTerminalError no longer seems to flake
after running it under stress on a GCE worker for a while, so this
change re-enables it.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@samiskin samiskin marked this pull request as ready for review March 13, 2023 13:08
@samiskin samiskin requested a review from a team as a code owner March 13, 2023 13:08
@samiskin samiskin requested review from jayshrivastava and removed request for a team March 13, 2023 13:08
Copy link
Contributor

@jayshrivastava jayshrivastava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samiskin
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 13, 2023

Build succeeded:

@craig craig bot merged commit 6a41a2f into cockroachdb:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl/changefeedccl: TestChangefeedPropagatesTerminalError flaky
3 participants