Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl/oidcccl: support principal matching on list claims #98522

Merged
merged 1 commit into from
Mar 18, 2023

Commits on Mar 16, 2023

  1. ccl/oidcccl: support principal matching on list claims

    Previously, matching on ID token claims was not possible if the claim key
    specified had a corresponding value that was a list, not a
    string. With this change, matching can now occur on claims that are list valued
    in order to add login capabilities to DB Console. It is important to note that
    this change does NOT offer the user the ability to choose between possible
    matches; it simply selects the first match to log the user in.
    
    This change also adds more verbose logging about ID token details.
    
    Epic: none
    Fixes: cockroachdb#97301, cockroachdb#97468
    
    Release note (enterprise change): The cluster setting
    `server.oidc_authentication.claim_json_key` for DB Console SSO
    now accepts list-valued token claims.
    
    Release note (general change): Increasing the logging verbosity
    is more helpful with troubleshooting DB Console SSO issues.
    cameronnunez committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    496d069 View commit details
    Browse the repository at this point in the history