ui: add PGCode to admin api errors #98601
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @dhartunian and @j82w)
-- commits line 13 at r1:
Yay!!
Just wondering if we should use PGCode or just Error Code
thoughts @kevin-v-ngo ?
Although the majority are PG error codes, we do have a subset of CRDB specific errors. So not opposed to just Error Code. |
Adding the Error Code makes it easy to identify the underlying issue of why the request failed. old error: ```RequestError: An internal server error has occurred. Please check your CockroachDB logs for more details.``` new error ```RequestError: An internal server error has occurred. Please check your CockroachDB logs for more details. Error Code: 53200``` Epic: none Closes: #98596 Release note: none
Previously, maryliag (Marylia Gutierrez) wrote…
I'm good either way. I went ahead and switched it to Error Code. |
There was a problem hiding this comment.
Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
|
can you also backport this to 22.2 and 22.1? |
There was a problem hiding this comment.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from b6e0f76 to blathers/backport-release-22.1-98601: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. error creating merge commit from b6e0f76 to blathers/backport-release-22.2-98601: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Adding the PGCode makes it easy to identify
the underlying issue of why the request failed.
old error:
new error
Epic: none
Closes: #98596
Release note: none