sql/schemachanger: relieve restrictions on zone config #98650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
fqazi
force-pushed
the
removeZoneConfigLimit
branch
4 times, most recently
from
0b7e850
to
3ddee96
Compare
fqazi
force-pushed
the
removeZoneConfigLimit
branch
3 times, most recently
from
a747272
to
6d97c1f
Compare
chengxiong-ruan
approved these changes
Mar 15, 2023
Previously, the declarative schema changer was blanket disabled for zone configurations. This was fairly restrictive and meant that the declarative schema changer would not be used when any zone config existed. To address this, this patch only blocks declarative schema changes when a sub zone config or regional by row elements exist. Epic: none Release note: None
fqazi
force-pushed
the
removeZoneConfigLimit
branch
from
6d97c1f
to
3c66440
Compare
|
@chengxiong-ruan TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the declarative schema changer was blanket disabled for zone configurations. This was fairly
restrictive and meant that the declarative schema changer would not be used when any zone config existed. To address this, this patch only blocks declarative schema changes when a sub zone config exists.
Epic: none
Release note: None