Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/logictest: clarify retry comment #98809

Merged
merged 1 commit into from
Mar 20, 2023
Merged

sql/logictest: clarify retry comment #98809

merged 1 commit into from
Mar 20, 2023
+3 −2

Conversation

mgartner
Copy link
Collaborator

@mgartner mgartner commented Mar 16, 2023 •
edited
Loading

Epic: None

Release note: None

@mgartner mgartner requested review from Shivs11 and a team March 16, 2023 20:13
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Shivs11
Shivs11 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@Shivs11 Shivs11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@mgartner
Copy link
Collaborator Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 20, 2023

Build succeeded:

@craig craig bot merged commit 5839fe0 into cockroachdb:master Mar 20, 2023
@mgartner mgartner deleted the improve-logictest-comments branch March 20, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shivs11 Shivs11 Shivs11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgartner @cockroach-teamcity @Shivs11