roachtest: deflake replicagc-changed-peers #99020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Let's fix master and backport to branch where actual test failure happened. Change seem applicable to both. |
aliher1911
force-pushed
the
deflage_replicagc_roachtest
branch
from
a543525
to
4439dd8
Compare
tbg
reviewed
Mar 20, 2023
aliher1911
force-pushed
the
deflage_replicagc_roachtest
branch
2 times, most recently
from
e646d59
to
73d970d
Compare
aliher1911
requested review from
srosenberg,
smg260,
a team and
tbg
and removed request for
a team
aliher1911
force-pushed
the
deflage_replicagc_roachtest
branch
3 times, most recently
from
02a019a
to
3a8d684
Compare
tbg
approved these changes
Mar 23, 2023
Test doesn't give enough time for allocator to see that node is dead and move replicas from killed node. This PR changes retry timeout and interval and adds extra logging for visibility. Release note: None
aliher1911
force-pushed
the
deflage_replicagc_roachtest
branch
from
3a8d684
to
b0c918d
Compare
|
bors r=tbg |
|
Build succeeded: |
|
blathers backport 23.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test doesn't give enough time for allocator to see that node is dead and move replicas from killed node. This PR changes retry timeout and interval and adds extra logging for visibility.
Release note: None
Fixes #98966