Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: deflake TestTrace #99062

Merged

Commits on Mar 20, 2023

  1. sql: deflake TestTrace

    This has been seen to flake in CI:
    
    ```
    === RUN   TestTrace/ShowTraceForVectorized/TracingOff/node-1
        trace_test.go:386: expected span: "session recording", got: "pendingLeaseRequest: requesting lease"
        trace_test.go:397: remaining span: "session recording"
        trace_test.go:397: remaining span: "sql query"
        trace_test.go:397: remaining span: "sql txn"
        trace_test.go:397: remaining span: "txn coordinator send"
                --- FAIL: TestTrace/ShowTraceForVectorized/TracingOff/node-1 (0.02s)
    ```
    
    There was already an exception for this span, but with a `storage.`
    prefix. This patch removes the prefix, and makes it match on substrings.
    
    This flake has possibly been made worse with the introduction of a
    metamorphic setting to only use expiration-based leases in ecc931b.
    
    Epic: none
    Release note: None
    erikgrinaker committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    c7641af View commit details
    Browse the repository at this point in the history