Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workload/schemachanger: basic declarative schema changer support #99368

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

fqazi
Copy link
Collaborator

@fqazi fqazi commented Mar 23, 2023

Previously, the randomized testing only supported, the non-declarative schema changer. This patch adds support for basic single statement transactions for testing the declarative schema changer

Note: This entablement is only focused on very
minimal stability testing. Not implemented errors
are always ignore for now.

Fixes: #77376

Release note: None

@fqazi fqazi requested a review from a team March 23, 2023 13:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, the randomized testing only supported,
the non-declarative schema changer. This patch adds support
for basic single statement transactions for testing
the declarative schema changer

Note: This entablement is only focused on very
minimal stability testing. Not implemented errors
are always ignored for now.

Informs: cockroachdb#98635

Release note: None
@fqazi fqazi marked this pull request as ready for review March 23, 2023 14:07
@fqazi fqazi requested a review from a team as a code owner March 23, 2023 14:07
@fqazi fqazi requested review from smg260 and renatolabs and removed request for a team March 23, 2023 14:07
Copy link
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fqazi
Copy link
Collaborator Author

fqazi commented Apr 4, 2023

bors r+

@fqazi
Copy link
Collaborator Author

fqazi commented Apr 4, 2023

@chengxiong-ruan TFTR!

@craig
Copy link
Contributor

craig bot commented Apr 4, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Apr 4, 2023

Build succeeded:

@craig craig bot merged commit 44f3f31 into cockroachdb:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: Add PR check to encourage including issue or epic refs in the PR/commit messages
3 participants