Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: streamingccl: skip acceptance/c2c on remote cluster setup #99818

Merged
merged 1 commit into from
Mar 28, 2023
Merged

release-23.1: streamingccl: skip acceptance/c2c on remote cluster setup #99818

merged 1 commit into from
Mar 28, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 28, 2023 •
edited by msbutler
Loading

Backport 1/1 commits from #99574 on behalf of @msbutler.

/cc @cockroachdb/release

acceptance/c2c currently fails when run on a remote cluster. This patch ensures the test gets skipped when run on a remote cluster. There's no need to run the test on a remote cluster because the other c2c roachtests provide sufficient coverage.

Fixes #99553

Release note: none

Release justification: test infra change

@msbutler
streamingccl: skip acceptance/c2c in remote cluster setup
2f366d6 
acceptance/c2c currently fails when run on a remote cluster. This patch ensures
the test gets skipped when run on a remote cluster. There's no need to run the
test on a remote cluster because the other c2c roachtests provide sufficient
coverage.

Fixes #99553

Release note: none
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 28, 2023 16:36
@blathers-crl blathers-crl bot removed the request for review from a team March 28, 2023 16:36
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99574 branch from bb11b30 to 8a31cba Compare March 28, 2023 16:36
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99574 branch from c7f80d1 to 2f366d6 Compare March 28, 2023 16:36
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 28, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 28, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler msbutler merged commit fe30759 into release-23.1 Mar 28, 2023
@msbutler msbutler deleted the blathers/backport-release-23.1-99574 branch March 28, 2023 17:33
@msbutler msbutler mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendanna stevendanna stevendanna approved these changes

@herkolategan herkolategan Awaiting requested review from herkolategan herkolategan is a code owner automatically assigned from cockroachdb/test-eng

@srosenberg srosenberg Awaiting requested review from srosenberg srosenberg is a code owner automatically assigned from cockroachdb/test-eng

Assignees

@msbutler msbutler

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @stevendanna @msbutler