Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for PostgreSQL compatibility #2256

Closed
jseldess opened this issue Dec 6, 2017 · 7 comments
Closed

Changes for PostgreSQL compatibility #2256

jseldess opened this issue Dec 6, 2017 · 7 comments
Assignees
Milestone

Comments

@jseldess
Copy link
Contributor

jseldess commented Dec 6, 2017

@jseldess jseldess added this to the 1.2 milestone Dec 6, 2017
@jseldess jseldess added ready and removed ready labels Jan 18, 2018
@jseldess
Copy link
Contributor Author

jseldess commented Mar 2, 2018

Need to update SET (session variable), SHOW (session variable), and SET TRANSACTION, where relevant.

It looks like we don't list some of the transaction variables on the set/show variables pages. Not sure why not.

@lnhsingh lnhsingh self-assigned this Apr 2, 2018
@lnhsingh
Copy link
Contributor

lnhsingh commented Apr 9, 2018

It seems like you can't interchangeably use TIME ZONE and TIMEZONE. @knz, can you help clarify? For example, if I SET TIME ZONE DEFAULT and then SET TIMEZONE EST, the second SET doesn't work unless I use SET TIMEZONE = EST. Why is this?

@lnhsingh
Copy link
Contributor

lnhsingh commented Apr 9, 2018

Also: The transaction_read_only can't be changed from off, so it seems misleading that you can SET transaction_read_only = FALSE / TRUE; and get a SET (even though nothing is changed). @justinj, is this just a wonky or should this be changed?

lnhsingh pushed a commit that referenced this issue Apr 9, 2018
@lnhsingh lnhsingh added in progress and removed ready labels Apr 9, 2018
@justinj
Copy link
Contributor

justinj commented Apr 9, 2018

Hm, yes, I think I assumed in that PR that attempting to set it would fail, we should fix that. Opened as cockroachdb/cockroach#24608

@knz
Copy link
Contributor

knz commented Apr 9, 2018

@lhirata: SET TIME ZONE xxx is a "special form", which has its own, special cased grammar rule, and gets automagically replaced to SET timezone = xxx.

This is similar to SET SESSION CHARACTERISTICS AS TRANSACTION ISOLATION LEVEL xxx which is a special form that gets automagically replaced to SET TRANSACTION ISOLATION LEVEL xxx

We already mention in the text it's a special form. The only thing that needs to change in the doc page is the name of the variable in the table, and further references to the variable in that page and other pages.

@knz
Copy link
Contributor

knz commented Apr 9, 2018

In the current text we say "SET TIME ZONE xxx is a special form for SET "time zone" = xxx". This text needs to be changed to "SET TIME ZONE xxx is a special form for SET timezone = xxx".

@lnhsingh
Copy link
Contributor

@knz thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants