Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vectorized setting with new name and defaults #5141

Closed
rmloveland opened this issue Aug 5, 2019 · 1 comment · Fixed by #5453
Closed

Update vectorized setting with new name and defaults #5141

rmloveland opened this issue Aug 5, 2019 · 1 comment · Fixed by #5453
Assignees
Labels
P-1 High priority; must be done this release
Milestone

Comments

@rmloveland
Copy link
Contributor

rmloveland commented Aug 5, 2019

tl;dr: sql.defaults.experimental_vectorize is now
sql.defaults.vectorize, and it has some new defaults.

Via @yuzefovich comment on #4953:

A quick note: we have just merged a PR ([cockroachdb/cockroach#38777][PR]) that renamed experimental_vectorize to just vectorize. It also added a new possible mode of vectorization, and now all modes are:

  • off - the vectorized engine is disabled, all queries go through the row execution engine.
  • auto (which is now the default choice) - all queries consisting only of streaming operators (a streaming operator is such that doesn't require any buffering) are executed through the vectorized engine whereas all others are run through the row execution engine.
  • experimental_on - all queries that are supported in the vectorized engine (both streaming and non-streaming) are run through it. It is "experimental" because we still don't have disk spilling (which means that large queries can get out of memory error and crash the node).
  • experimental_always - absolutely all queries are forced to run through the vectorized engine. If the engine doesn't support the query, it errors out. The only exception is SET queries so that vectorize session variable can be changed.>
    [PR]: exec: add "auto" vectorize setting and make it default cockroach#38777
@rmloveland rmloveland added A-sql P-1 High priority; must be done this release labels Aug 5, 2019
@rmloveland rmloveland added this to the 19.2 milestone Aug 5, 2019
@yuzefovich
Copy link
Member

Another quick note: cockroachdb/cockroach#39285 removed experimental_always from the list of valid options for cluster setting sql.defaults.vectorize; however, it is still possible to set session variable vectorize to experimental_always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-1 High priority; must be done this release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants