sql: remove 'experimental_always' as an option for vectorize cluster setting #39285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
reviewed
Aug 3, 2019
yuzefovich
force-pushed
the
vec-cluster-setting
branch
2 times, most recently
from
092a314
to
c16b7e3
Compare
yuzefovich
changed the title
|
I didn't even realize it was an option! Thanks, it's a lot cleaner this way. Also, is there a way to "advertise" |
jordanlewis
approved these changes
Aug 5, 2019
…setting If we allow such thing, then it is quite painful to reset the cluster setting. It is also quite tricky to allow the corresponding query to go around the vectorized engine when the vectorize cluster setting is 'experimental_vectorize` even if the session variable is 'off' because the internal executor uses the cluster setting. Release note: None
yuzefovich
force-pushed
the
vec-cluster-setting
branch
from
c16b7e3
to
0ea31a8
Compare
|
I guess if someone really wants to use TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 5, 2019
39285: sql: remove 'experimental_always' as an option for vectorize cluster setting r=yuzefovich a=yuzefovich If we allow such thing, then it is quite painful to reset the cluster setting. It is also quite tricky to allow the corresponding query to go around the vectorized engine when the vectorize cluster setting is 'experimental_vectorize` even if the session variable is 'off' because the internal executor uses the cluster setting. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we allow such thing, then it is quite painful to reset the
cluster setting. It is also quite tricky to allow the corresponding
query to go around the vectorized engine when the vectorize cluster
setting is 'experimental_vectorize` even if the session variable is
'off' because the internal executor uses the cluster setting.
Release note: None